[Red5] BaseRTMPClientHandler patch

[Thijs Triemstra | Collab]

Hi Prabhu,

any chance you could supply some unit tests for this patch as well?  
Otherwise it's hard to tell if it won't break things.

Cheers,

Thijs

On 3 nov 2008, at 20:25, Prabhu Tamilarasan (omNovia) wrote:

> Strange, maybe it should be Double everywhere then.
>
>
>
> next generation web conferencing
> Prabhu Tamilarasan
> Senior Software Engineer
> 675 Bering Drive, Suite 290
> Houston, TX 77057 USA
> www.omnovia.com
> ptamilarasan at omnovia.com
> T +1.281.500.4065 x 731
>
> From: red5-bounces at osflash.org [mailto:red5-bounces at osflash.org] On  
> Behalf Of .
> Sent: Monday, November 03, 2008 2:08 PM
> To: red5 at osflash.org
> Subject: Re: [Red5] BaseRTMPClientHandler patch
>
> I have actually had to change a different cast to a Double when  
> connecting to FMS
>
> On line 527 of the same class, I changed:
>
> Integer encoding = (Integer) connectionParams
>
> to
>
> Double encoding = (Double) connectionParams
>
> just fyi...
> On Mon, Nov 3, 2008 at 8:56 AM, Prabhu Tamilarasan (omNovia) <ptamilarasan at omnovia.com 
> > wrote:
> Here is a small patch to fix connecting from one Red5 server to  
> another using RTMPClient.  For some reason in one of the overloaded  
> connect functions the objectEncoding is added as a double and there  
> is an error later in onInvoke trying to cast the objectEncoding to  
> int.
>
>
>
> # svn diff BaseRTMPClientHandler.java
>
> Index: BaseRTMPClientHandler.java
>
> ===================================================================
>
> --- BaseRTMPClientHandler.java  (revision 3321)
>
> +++ BaseRTMPClientHandler.java  (working copy)
>
> @@ -271,7 +271,7 @@
>
>                 this.connectArguments = connectCallArguments;
>
>
>
>                 if (!connectionParams.containsKey("objectEncoding")) {
>
> -                       connectionParams.put("objectEncoding",  
> (double) 0);
>
> +                       connectionParams.put("objectEncoding", (int)  
> 0);
>
>                 }
>
>
>
>                 this.connectCallback = connectCallback;
>
>
>
>
>
> Error! Filename not specified.
> next generation web conferencing
>
> Prabhu Tamilarasan
> Senior Software Engineer
>
> 675 Bering Drive, Suite 290
> Houston, TX 77057 USA
> www.omnovia.com
>
> ptamilarasan at omnovia.com
>
> T +1.281.500.4065 x 731
>
>
>
>
> _______________________________________________
> Red5 mailing list
> Red5 at osflash.org
> http://osflash.org/mailman/listinfo/red5_osflash.org
>
> _______________________________________________
> Red5 mailing list
> Red5 at osflash.org
> http://osflash.org/mailman/listinfo/red5_osflash.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://osflash.org/pipermail/red5_osflash.org/attachments/20081104/29d64541/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part
URL: <http://osflash.org/pipermail/red5_osflash.org/attachments/20081104/29d64541/attachment-0001.bin>