[Red5devs] Fwd: [Red5] Record with 'append' breaks timestamps - *Patch Included*

[Thijs Triemstra | Collab]

Can someone check out the patch supplied by Adam that tries to fix:
http://jira.red5.org/browse/APPSERVER-183

Cheers,

Thijs

Begin forwarded message:

> From: Adam <adam at gemin-i.org>
> Date: February 19, 2008 5:24:01 PM GMT+01:00
> To: red5 at osflash.org
> Subject: [Red5] Record with 'append' breaks timestamps - *Patch  
> Included*
> Reply-To: red5 at osflash.org
>
> I find that when I record a stream 'appended' onto another stream,
> it resets the timestamps in the flv to zero, meaning that seek()
> will find the wrong place, and the wrong length will be reported
> for the flv too.
>
> I asked about this last week, but got no reply, so I've looked
> into it myself so I can get my app working.
>
> The simplest way I found to fix it is to include code in
> src/org/red5/io/flv/impl/FLVReader.java to notice when the
> timestamps jump backwards and increment them by the
> appropriate amount to stop the discontinuity.
>
> I'm not really sure this is the correct solution to the problem,
> it's possible that the code *recording* the flv is at fault rather
> than the code replaying it, but it's certainly sufficient to fix
> my app, allow me to seek() within the discontinuous streams
> and get the right video length reported.
>
> Attached is a patch to do this, in case it's useful to anyone
> else. My app works with this patched Red5 at least.
>
> Adam............_______________________________________________
> Red5 mailing list
> Red5 at osflash.org
> http://osflash.org/mailman/listinfo/red5_osflash.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://osflash.org/pipermail/red5devs_osflash.org/attachments/20080219/9c62e525/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Red5-FLVReader-FixDiscontinuousTimestamps.patch
Type: application/octet-stream
Size: 1967 bytes
Desc: not available
Url : http://osflash.org/pipermail/red5devs_osflash.org/attachments/20080219/9c62e525/attachment.obj 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://osflash.org/pipermail/red5devs_osflash.org/attachments/20080219/9c62e525/attachment-0001.html