[Red5devs] Mavenized Red5

[Art Clarke]

Hi Michael,

Post your edits in jira, and assign to me, and I'll take a look.

- Art

On Fri, Jan 16, 2009 at 3:25 PM, Michael <michael.guymon at gmail.com> wrote:
> I agree entirely and am not trying to evangelize Maven for Red5 (if it ain't
> broken, why fix it). It would just make it easier for me to maintain my
> downstream branch if some of the modifications I made could trickle back
> into the trunk.
>
> thanks,
> Michael
>
> On Fri, Jan 16, 2009 at 4:04 PM, Art Clarke <aclarke at xuggle.com> wrote:
>>
>> Hi Michael,
>>
>> Can you go ahead and create the Jira reports as you suggest.  Right
>> now we have no plans to make a maven-ized version of Red5 (our
>> experience is that supporting once dependency management framework is
>> hard enough; two is an opportunity to disappoint).  That said, we
>> would consider patches to the ExtendedPorpertyPlaceholderConfigureer.
>>
>> - Art
>>
>> On Fri, Jan 16, 2009 at 8:44 AM, Michael <michael.guymon at gmail.com> wrote:
>> > Thanks for the suggestion, updating to trunk (rev 3371) fixed all the
>> > tests,
>> > http://sprocket.slackworks.com/red5/site/surefire-report.html
>> >
>> > I made some non-specific tweaks so that my Maven abuse would work. In
>> > particular, I extended the PropertyPlaceHolderConfigurer to allow for
>> > wildcard locations,
>> >
>> > http://github.com/mguymon/red5-mavenized/blob/bb9cfa663693f3567a424dfc5f1309738321504e/red5_base/src/main/java/org/red5/spring/ExtendedPropertyPlaceholderConfigurer.java.
>> >
>> > This allows projects that use the red5 jars to have a
>> > red5-any_name_really.properties and it will override the default
>> > red5.properties. The Spring bean definition would be as follows:
>> >
>> >    <bean id="placeholderConfig"
>> >         class="org.red5.spring.ExtendedPropertyPlaceholderConfigurer">
>> >         <property name="wildcardLocations">
>> >             <list>
>> >                 <value>classpath:/red5.properties</value>
>> >                 <value>classpath*:/red5-*.properties</value>
>> >             </list>
>> >         </property>
>> >     </bean>
>> >
>> > For these changes to be considered, should I create Jira enchancement
>> > tickets and upload patchs?
>> >
>> > thanks,
>> > Michael
>> >
>> > On Sun, Jan 11, 2009 at 1:45 PM, Art Clarke <aclarke at xuggle.com> wrote:
>> >>
>> >> Inline comments.
>> >>
>> >> On Sun, Jan 11, 2009 at 10:28 AM, Michael <michael.guymon at gmail.com>
>> >> wrote:
>> >> > Looks like those Hudson builds are from the Red5 trunk? I am trying
>> >> > to
>> >> > get
>> >> > the 0.8rc1 tests to run. Looks like some tests have been fixed in
>> >> > trunk,
>> >> > such as the HMACTest, which use to throw a null pointer in 0.8rc1,
>> >> > but
>> >> > it
>> >> > looks like it is commented out in trunk (broken test choosen at
>> >> > random).
>> >> Yeah, sorry;  Tests do not pass in 0.8rc1 (in fact, that's one of the
>> >> main reason we set up the hudson server).
>> >>
>> >> >
>> >> > Most of my errors stem from changes to the Spring contexts and moving
>> >> > resources from file to classpath locations, I am trying to find the
>> >> > line
>> >> > in
>> >> > the sand where my problems are self inflicted vs Red5 code "still in
>> >> > the
>> >> > works". A copy of my Maven test report from my build is at
>> >> > http://sprocket.slackworks.com/red5/site/surefire-report.html
>> >> I had similar problems getting the tests to work in trunk, and
>> >> addressed most of those issues.  You may want to try mavenizing trunk
>> >> instead of rc1 as it's got a lot of VERY important fixes in it (for
>> >> example, the rc1 release had broken classloaders) that make rc1
>> >> somewhat fragile.
>> >>
>> >> - Art
>> >>
>> >> _______________________________________________
>> >> Red5devs mailing list
>> >> Red5devs at osflash.org
>> >> http://osflash.org/mailman/listinfo/red5devs_osflash.org
>> >
>> >
>> > _______________________________________________
>> > Red5devs mailing list
>> > Red5devs at osflash.org
>> > http://osflash.org/mailman/listinfo/red5devs_osflash.org
>> >
>> >
>>
>> _______________________________________________
>> Red5devs mailing list
>> Red5devs at osflash.org
>> http://osflash.org/mailman/listinfo/red5devs_osflash.org
>
>
> _______________________________________________
> Red5devs mailing list
> Red5devs at osflash.org
> http://osflash.org/mailman/listinfo/red5devs_osflash.org
>
>